feat(react-native): default release mode to event - #4706
Closed
ablaszkiewicz wants to merge 3 commits into
Closed
Conversation
Source maps, dSYMs and R8 mappings upload release-independent by default, and each event resolves its own release. The resolved mode is written into the generated phases, so a build does not inherit the posthog-cli default. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jg6r6rFUBnowrXssZyU7yR
posthog-ios is moving to uploading dSYMs unbound by default, so a symbol-set phase that exports nothing would read as event. Both arms now export POSTHOG_NO_RELEASE_BIND, and the previous block stays recognized so projects prebuilt by an earlier SDK still get refreshed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jg6r6rFUBnowrXssZyU7yR
Contributor
Contributor
|
Size Change: +2.42 kB (+0.01%) Total Size: 20.8 MB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
🦔 PostHog Review reviewed this pull requestFound 0 must fix, 2 should fix, 1 consider. Published 3 findings (view the review). |
This was referenced Aug 31, 2026
Contributor
|
PostHog Review alpha 🦔 If you find any issues helpful - please reply "valid", "invalid", etc., for evaluation purposes 🙏 |
![posthog[bot]](https://avatars.githubusercontent.com/in/1203049?s=60&v=4){kind=small}
The prebuild writes the resolved mode into the Xcode phases and into gradle.properties, and both beat the environment variable at build time. An absent prop now reads POSTHOG_RELEASE_MODE before it falls back to event, so the documented opt-out works again. The prop documentation described the old default. A prebuild now also warns when the project pins com.posthog.android below 1.5.0, which ignores posthog.releaseMode and leaves the two halves on different modes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jg6r6rFUBnowrXssZyU7yR
ablaszkiewicz
force-pushed
the
feat/react-native-event-release-mode-default
branch
from
September 1, 2026 10:18
42678fd to
4c6ff0b
Compare
Contributor
Author
|
Closing this. We are removing event release mode from this package instead of defaulting to it. Event mode only helps when two releases ship a byte-identical artifact. The symbol id is a content hash on every platform, so an ordinary feature release already gets its own symbol set and never collides. The case that does collide is a React Native release that changes only JavaScript, where the native artifact repeats. Against that narrow benefit, the mobile paths carry real cost. A dSYM upload covers every embedded target but creates one release, so an extension crash resolves no release once the binding is gone. A replacement PR follows that removes the mode from this package. The flag was experimental and undocumented, so the removal is direct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs
Event mode is live today. Each build must ask for it. These PRs make it the default. The modes themselves do not change.
Problem
Changes
releaseModeresolves toeventin the Expo config plugin,posthog.gradleandposthog-xcode.sh.POSTHOG_RELEASE_MODE. An Expo project must set the variable before the prebuild runs.com.posthog.androidbelow 1.5.0. That version ignoresposthog.releaseMode.POSTHOG_NO_RELEASE_BINDfor both modes.releaseMode: 'symbol-set'keeps the old behavior.posthog.releaseMode=symbol-setandPOSTHOG_RELEASE_MODE=symbol-setdo the same.Land PostHog/posthog-ios#789 with this PR. That PR changes the posthog-ios default, so a symbol-set phase must name the opt-out.
How did you test this code?
jestinpackages/react-native.POSTHOG_NO_RELEASE_BIND=0.POSTHOG_SKIP_CLI_VERSION_CHECK=1. They use posthog-cli 0.15.x, below the event mode floor.findOutdatedPostHogAndroidPluginVersioncovers 1.4.0, 0.9.9, 1.5.0, 1.5.2, 2.0.0 and a project with no classpath.🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Written with Claude Code (Opus 5). Skills invoked:
/writing-pr-descriptions.resolveReleaseModePropreturnsPostHogReleaseMode, notPostHogReleaseMode | undefined. The builders keep the optional parameter, because the plugin matches old dSYM phases by exact text.The dSYM export came out of a review against the posthog-ios PR. Together the two PRs would otherwise unbind the dSYMs of a symbol-set build.