fix(agents): stop unversioned builds pointing prompts at the latest release - #379
Draft
posthog[bot] wants to merge 1 commit into
Draft
Conversation
An unversioned build wrote agent-menu.json with download URLs under releases/latest/download. The menu then listed prompts that the latest release does not carry, so a flow that is still on a branch failed the whole wizard run with a bare 404. A build without a version now points each prompt at the file it just wrote in dist/agents/, and the build log says the prompts are local. AGENTS_BASE_URL still wins, which is how the dev server serves them over HTTP. Generated-By: PostHog Desktop Task-Id: f6cb3801-fedd-410b-8955-ede0c97ce2a7
Author
🦔 PostHog Review reviewed this pull requestNothing worth raising this time, so here's a calming picture instead:
|
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a wizard branch:
Add Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
defaultAgentsBaseUrlfell back toreleases/latest/download. The locally builtagent-menu.jsonthen advertised prompts that the latest release does not carry.Changes
dist/agents/.downloadUrlbaseBUILD_VERSION=1.50.0.../releases/download/v1.50.0(no change)AGENTS_BASE_URLset (dev server)npm run build)file://<repo>/dist/agents(wasreleases/latest/download)npm run buildprints one line when the prompts are local, and names the two ways to serve them elsewhere.Note
This fixes the build side only. A wizard-side error that names the unpublished flow is still worth adding, and
resolveBaseDownloadUrlinscripts/lib/build-phases.jshas the same fallback for skill ZIPs. Neither is in this PR.Agent context
npm run buildis the documented local check in AGENTS.md, and a hard failure would block every contributor who builds without a version.scripts/mirror-dist.jsrewrites both release bases, but it runs only with a real version, so the local base never reaches the mirror.npm test(175 pass) and a localnpm run build: the menu holdsfile://URLs that resolve to real files, and the warning prints.Created with PostHog Desktop from this inbox report.