Substrate stable2603-4, remove old pallet-contracts support.#1969
Open
Neopallium wants to merge 8 commits into
Open
Substrate stable2603-4, remove old pallet-contracts support.#1969Neopallium wants to merge 8 commits into
Neopallium wants to merge 8 commits into
Conversation
e4400bc to
33a6f32
Compare
33a6f32 to
53bc8c4
Compare
53bc8c4 to
685a271
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Polymesh node to the polymesh-v8-stable2603-4 polkadot-sdk branch and removes legacy pallet-contracts / polymesh-contracts support across runtimes, chain specs, weights, and integration testing infrastructure.
Changes:
- Bump polkadot-sdk dependency branches to
polymesh-v8-stable2603-4. - Remove the
polymesh-contractspallet, its chain extension, benchmarks, and associated runtime/config/weights/genesis wiring. - Adjust runtimes/configs/tests to reflect the removal (including ED changes and related cleanup).
Reviewed changes
Copilot reviewed 40 out of 49 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Updates polkadot-sdk branches and removes pallets/contracts + polymesh-contracts workspace/deps. |
src/data/contracts_call_whitelist.txt |
Removes legacy informational whitelist mapping (file deleted). |
src/data/contracts_call_whitelist.json |
Removes legacy contracts call whitelist data (file deleted). |
src/chain_spec/ci_runtime.rs |
Drops polymeshContracts genesis config entry/import. |
src/chain_spec/common.rs |
Removes polymesh_contracts_genesis_config + whitelist/wasm helpers and related imports. |
src/chain_spec/develop_runtime.rs |
Drops polymeshContracts genesis config entry/import. |
src/chain_spec/mainnet_runtime.rs |
Drops polymeshContracts genesis config entry/import. |
src/chain_spec/testnet_runtime.rs |
Drops polymeshContracts genesis config entry/import. |
pallets/contracts/Cargo.toml |
Removes the polymesh-contracts pallet crate manifest (file deleted). |
pallets/contracts/src/benchmarking.rs |
Removes polymesh-contracts benchmarking code (file deleted). |
pallets/contracts/src/chain_extension.rs |
Removes Polymesh contracts chain extension implementation (file deleted). |
pallets/contracts/src/lib.rs |
Removes polymesh-contracts pallet implementation (file deleted). |
pallets/relayer/src/lib.rs |
Fixes relayer migration guard to run only when on-chain version is behind in-code version. |
pallets/runtime/common/src/runtime.rs |
Removes pallet-contracts / polymesh-contracts runtime config + runtime API wiring; keeps pallet_revive. |
pallets/runtime/develop/Cargo.toml |
Removes pallet-contracts / polymesh-contracts deps and benchmark/std feature wiring. |
pallets/runtime/develop/src/runtime.rs |
Removes contracts-related parameter types and bench entries; cleans up ED benchmark constant. |
pallets/runtime/mainnet/Cargo.toml |
Removes pallet-contracts / polymesh-contracts deps and benchmark/std feature wiring. |
pallets/runtime/mainnet/src/runtime.rs |
Removes contracts-related parameter types and sets ED to 1u128. |
pallets/runtime/testnet/Cargo.toml |
Removes pallet-contracts / polymesh-contracts deps and benchmark/std feature wiring. |
pallets/runtime/testnet/src/runtime.rs |
Removes contracts-related parameter types and sets ED to 1u128. |
pallets/runtime/tests/Cargo.toml |
Removes pallet-contracts / polymesh-contracts deps and std feature wiring for the tests runtime. |
pallets/runtime/tests/src/lib.rs |
Removes contracts_test module from the runtime tests crate. |
pallets/runtime/tests/src/storage.rs |
Removes contracts pallets from the test runtime and removes contracts-specific parameter types; adjusts ED. |
pallets/weights/Cargo.toml |
Removes pallet-contracts / polymesh-contracts deps and std feature wiring from the weights crate. |
pallets/weights/src/lib.rs |
Removes module exports for contracts weight files. |
pallets/weights/src/pallet_contracts.rs |
Removes autogenerated weights for pallet_contracts (file deleted). |
pallets/weights/src/polymesh_contracts.rs |
Removes autogenerated weights for polymesh_contracts (file deleted). |
integration/contracts/rust-toolchain.toml |
Removes contracts-specific Rust toolchain pin (file deleted). |
integration/contracts/call_runtime-tester/.gitignore |
Removes contract test project ignore file (file deleted). |
integration/contracts/call_runtime-tester/Cargo.toml |
Removes contract test project manifest (file deleted). |
integration/contracts/call_runtime-tester/lib.rs |
Removes contract test project source (file deleted). |
integration/contracts/contract-revert/.gitignore |
Removes contract revert test project ignore file (file deleted). |
integration/contracts/contract-revert/Cargo.lock |
Removes contract revert test project lockfile (file deleted). |
integration/contracts/contract-revert/Cargo.toml |
Removes contract revert test project manifest (file deleted). |
integration/contracts/contract-revert/lib.rs |
Removes contract revert test project source (file deleted). |
integration/src/lib.rs |
Removes helper for reading Contracts::Instantiated event (contract deployment helper). |
integration/tests/contract_permissions.rs |
Removes integration test for contract permissions/identity swapping (file deleted). |
integration/tests/contract_revert.contract |
Removes compiled contract bundle used by integration tests (file deleted). |
integration/tests/contract_revert.json |
Removes contract metadata used by integration tests (file deleted). |
integration/tests/contract_revert.rs |
Removes integration test for reverted constructor behavior (file deleted). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog
other
ExistentialDepositof all runtimes to lowest non-zero value.stable2603-4release.pallet_contracts). Smart contracts should now use the Revive pallet.data migration