Impl ERC20 precompile interface#1965
Open
HenriqueNogara wants to merge 8 commits into
Open
Conversation
Neopallium
approved these changes
Jun 29, 2026
Comment on lines
+216
to
+223
| Self::deposit_event( | ||
| env, | ||
| IERC20Events::Transfer(IERC20::Transfer { | ||
| from: caller.0.into(), | ||
| to: call.to, | ||
| value: call.value, | ||
| }), | ||
| )?; |
Contributor
There was a problem hiding this comment.
I wonder if we will need to emit EVM-compatible transfer events from Substrate-issued asset transfer calls.
Neopallium
requested changes
Jul 6, 2026
| let next_index = asset_index.saturating_add(1); | ||
| NextAssetIndex::<T>::put(next_index); | ||
| writes += 3; | ||
| reads += 2; |
Contributor
There was a problem hiding this comment.
I think there is only one read NextAssetIndex::<T>::get inside the loop right now.
Contributor
Author
There was a problem hiding this comment.
One read is for the Assets storage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog
new features
other