fix(rfq): support balance error codes#98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linear: DEV-265
Verification
uv run pytest tests/integration/test_rfq.py -k quote_rejection -q(skipped locally: requiresPOLYMARKET_PRIVATE_KEY/POLYMARKET_DEPOSIT_WALLET)uv run ruff check src testsuv run pyrightNote
Low Risk
Enum and test-only changes with no RFQ session or wire-protocol behavior changes beyond recognizing new error code strings.
Overview
Extends the public
RfqErrorCodeenum with three Combos RFQ wire codes:ALLOWANCE_VALIDATION_FAILED,BALANCE_VALIDATION_FAILED, andPRE_EXECUTION_BALANCE_RESERVATION_FAILED, so clients can distinguish balance/allowance/reservation failures from generic quote errors.The RFQ websocket quote-rejection integration test is parametrized over those codes and now asserts
RfqQuoteRejectedError.codematches the serverRFQ_ERRORpayload (previously onlyINVALID_QUOTEwas exercised).Reviewed by Cursor Bugbot for commit 2b71c99. Bugbot is set up for automated code reviews on this repo. Configure here.