fix(models): normalize empty-string trade and position icons to None#97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sparse historical rows serialize missing market icons as
"". The activity models already normalize this toNone(PR #94); the looseTrademodel and thePosition/ClosedPositionmodels still passed""through to the publiciconfields.This adds an
iconbefore-validator using the existingempty_string_to_nonehelper on those three models, so missing icons consistently surface asNoneacross the data surface.Live evidence: 48/500 trades and 2/143 positions with
icon: ""for a wallet with sparse historical rows.Linear: DEV-264. Counterpart of ts-sdk PR #124 (DEV-263).
Verification
iconparses toNoneonTrade,Position, andClosedPosition; populated icons unchanged.uv run pytest tests/unit -q: 1701 passed.uv run ruff check .,uv run ruff format --check .: clean.uv run pyright: 0 errors.None.Note
Low Risk
Parsing-only normalization on optional display fields; behavior change is limited to
""→Nonewith tests covering regressions.Overview
Aligns missing market icon handling on the loose
Trademodel andPosition/ClosedPositionwith activity parsing: API rows that sendicon: ""now surface asNoneinstead of empty strings.Each model gets a
beforevalidator oniconthat delegates to the sharedempty_string_to_nonehelper (same pattern as activity models after PR #94). Non-empty icon URLs are unchanged.Unit tests cover empty vs populated
icononTrade,Position, andClosedPosition.Reviewed by Cursor Bugbot for commit 5949925. Bugbot is set up for automated code reviews on this repo. Configure here.