Fix events list default closed filter#83
Open
DeepCogNeural wants to merge 1 commit into
Open
Conversation
ad8b5c9 to
7b63a0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
events listsendclosed=falseby default when neither--closednor--activeis provided.--closedbehavior and the existing--activetoclosedmapping.closedfilter, covering default behavior, explicit--closed,--active true,--active false, and--closedprecedence.Why
Gamma
/eventscurrently returns closed events when theclosedquery parameter is omitted. The CLI should request open events by default.Fixes #71
Validation
cargo fmt --checkcargo clippy -- -D warningscargo testNote
Low Risk
Localized CLI query-parameter default for events listing; no auth or data-path changes.
Overview
events listnow always sends an explicitclosedquery parameter instead of omitting it when neither--closednor--activeis set. The default isclosed=false(open events), matching expected CLI behavior when Gamma returns closed events ifclosedis missing.List request construction is moved into
build_events_list_request, which resolves filters as: explicit--closedwins; otherwise--activemaps toclosed = !active; otherwisefalse.--active/--closedcombinations from before are preserved (e.g.--activealone still impliesclosed=false).A unit test (
events_list_resolves_closed_filter) locks in those resolution cases.Reviewed by Cursor Bugbot for commit 7b63a0c. Bugbot is set up for automated code reviews on this repo. Configure here.