Skip to content

PR/02 - CI Build fixes - Fix JS notebook entrypoints and improve test run output - #16

Open
sassdawe wants to merge 4 commits into
Polyglossy:mainfrom
sassdawe:pr/02-ci-build-fixes
Open

PR/02 - CI Build fixes - Fix JS notebook entrypoints and improve test run output#16
sassdawe wants to merge 4 commits into
Polyglossy:mainfrom
sassdawe:pr/02-ci-build-fixes

Conversation

@sassdawe

@sassdawe sassdawe commented Aug 6, 2026

Copy link
Copy Markdown
Member

This pull request introduces several improvements to the build and test infrastructure, focusing on better output path handling when Arcade is disabled, and more reliable and organized test result logging. The changes also update TypeScript and Rollup build steps for the browser and core packages to ensure the correct input files are used after compilation.

Build and Output Path Handling:

  • Added a conditional property group in Directory.Build.props to replicate Arcade's output directory structure (artifacts/bin/<ProjectName>/<Configuration>) when Arcade is disabled, ensuring that dotnet test --no-build can locate the correct assemblies.

Test Infrastructure Improvements:

  • Enhanced test-retry-runner.ps1 to generate unique, safe, and descriptive .trx test result filenames for each test run and retry, preventing filename collisions and making test results easier to analyze. This includes the addition of a helper function to sanitize filenames. [1] [2] [3]

Build Script Updates:

  • Updated the compile and rollup scripts in src/polyglot-notebooks-browser/package.json to ensure TypeScript compilation runs before bundling and to use the compiled JavaScript as input for Rollup, improving build reliability.
  • Modified the compile-es-module and compile-library scripts in src/polyglot-notebooks/package.json to use compiled output from dist as input for bundling, aligning with best practices for build pipelines.

sassdawe and others added 4 commits July 19, 2026 13:59
key changes: explicit TRX filename per run, quote paths safely, sanitize test class names, create results dir up front
@sassdawe
sassdawe requested a review from jonsequitur August 6, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant