PR/02 - CI Build fixes - Fix JS notebook entrypoints and improve test run output - #16
Open
sassdawe wants to merge 4 commits into
Open
PR/02 - CI Build fixes - Fix JS notebook entrypoints and improve test run output#16sassdawe wants to merge 4 commits into
sassdawe wants to merge 4 commits into
Conversation
key changes: explicit TRX filename per run, quote paths safely, sanitize test class names, create results dir up front
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the build and test infrastructure, focusing on better output path handling when Arcade is disabled, and more reliable and organized test result logging. The changes also update TypeScript and Rollup build steps for the browser and core packages to ensure the correct input files are used after compilation.
Build and Output Path Handling:
Directory.Build.propsto replicate Arcade's output directory structure (artifacts/bin/<ProjectName>/<Configuration>) when Arcade is disabled, ensuring thatdotnet test --no-buildcan locate the correct assemblies.Test Infrastructure Improvements:
test-retry-runner.ps1to generate unique, safe, and descriptive.trxtest result filenames for each test run and retry, preventing filename collisions and making test results easier to analyze. This includes the addition of a helper function to sanitize filenames. [1] [2] [3]Build Script Updates:
compileandrollupscripts insrc/polyglot-notebooks-browser/package.jsonto ensure TypeScript compilation runs before bundling and to use the compiled JavaScript as input for Rollup, improving build reliability.compile-es-moduleandcompile-libraryscripts insrc/polyglot-notebooks/package.jsonto use compiled output fromdistas input for bundling, aligning with best practices for build pipelines.