90 Refine calibration constant selection. - #91
Open
HavardStridBuholdt wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Merge #87 before this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing issue #90
Also added default calibration constants.
Had to redefine how we store the calibration constants. The structure of
data_cube.pol_calianddata_cube.LCare still the same but they now include and additional entrydefaultthat stores the default constants per channel.data_cube.etausedanddata_cube.LCusedare now nested dictionaries with entries{'eta'/'LC': ... , 'eta_std'/'LCStd': ..., 'method': ...}per channel. Themethodentry shows where the chosen calibration constant comes from,D90,D90_db,klett,raman,klett_db,raman_db, ordefault.Default constants are only selected if no other exists.
The update also introduces the following new config variable dependencies:
flagDepolCali: enable or disable the retrieval of DCs from the measurement.flagLCCalibration: enable or disable the retrieval of LCs from the measurement.flagUsePreviousDepolCali: enable or disable the loading of DCs from the database.flagUsePreviousLC: enable or disable the loading of LCs from the database.calibrationDB: now used to construct a default database-path if the loading of CCs is enabled but no path was given in the function input.If both the retrieval of CCs from the measurement and the loading of CCs form the database is disabled, the default values will always be chosen.