fix: open one main landmark on the shop pages - #12
Merged
Merged
Conversation
The layout opens div#primary and main#main. WooCommerce's default content wrapper opened both a second time, inside them, on every page it renders: product grid, product page, search, cart. Two main landmarks, and two elements sharing each id. The theme now removes that wrapper.
The framework aliases develop to 13.x-dev since #335, so composer show lists 13.x-dev before dev-develop and the develop leg tried to clone a branch named 13.x-dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The layout (
layouts/app.blade.php) opensdiv#primaryandmain#main. WooCommerce's default content wrapper (woocommerce_output_content_wrapper/_end, hooked onwoocommerce_before_main_content/woocommerce_after_main_content) opened both a second time inside them, on every page WooCommerce renders — not only the product search noted in the handover. Twomainlandmarks, two elements withid="main"and two withid="primary".The theme removes the wrapper on
woocommerce_init, as it already does for the breadcrumb.Checked on pollora-test
<main>beforeA new spec, "each shop page has one main landmark" (
shop.spec.ts), checks the product grid, a product page, a product search and the cart. Replayed: without the fix it fails (product grid: main elements, expected 1, received 2); with it, it passes.Also: CI of the develop leg
Since framework #335 aliases
developto13.x-dev,composer show pollora/frameworklists["13.x-dev", "dev-develop"]. The step fetching the framework's E2E harness read.versions[0]and tried to clone a branch named13.x-dev(Remote branch 13.x-dev not found), failing both "framework develop" legs of any run. It now picksdevelopwhendev-developis anywhere in the list. Checked withjqon the three shapes (["13.x-dev","dev-develop"],["dev-develop"], a tag) and by this PR's run: all 6 jobs green.