fix: enqueue the Vite client with no version - #366
Merged
Merged
Conversation
The modules Vite serves import /@vite/client by its bare URL; enqueued with WordPress's version appended, the client loaded twice, as two modules with two HMR connections. Regression from v13.34.0-beta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #357 (v13.34.0-beta), found while testing a stale hot file: the dev server's client was enqueued as
@vite/client?ver=7.1.2(wp_enqueue_script_module()'s version defaults to WordPress's). The modules Vite serves import/@vite/clientby its bare URL, and a module is identified by its URL — so the browser loaded the client twice, with two HMR connections. The entries were already enqueued with anullversion; the client now is too. The existing test asserts the version; it fails on the previous code.