revert: drop .html block patterns, before they ship - #359
Merged
Merged
Conversation
Reverts #354, never released. A theme's static patterns belong in patterns/*.php at its root, which WordPress registers natively (and the Site Editor exports): the .html format duplicated that in a format only Pollora knew, and mixed static markup into resources/views, which is otherwise Blade only. resources/views/patterns keeps .blade.php patterns, for those that need Laravel. This reverts commit 9cf62fc, reversing changes made to 81336d7.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #354, which has not been released (it only sat in
[Unreleased]).Why
A theme's static patterns belong in
patterns/*.phpat its root: WordPress registers them natively — checked in a Pollora theme — and that is the layout the Site Editor (Create Block Theme) exports, and themes such as Ollie use (115 patterns, all.php)..htmlinresources/views/patternsduplicated that in a format only Pollora knew, and mixed static markup intoresources/views, which is otherwise Blade only.The rule that follows: the theme root holds what WordPress reads itself (
templates/,parts/,patterns/,theme.json,style.css);resources/views/holds Blade.resources/views/patterns/*.blade.phpstays, for a pattern that needs Laravel.Buzz, the only user, has moved its six
.htmlpatterns topatterns/*.php(Pollora/theme-buzz#2, merged). That move also made it work on the released beta.9, where.htmlpatterns never rendered.Change
git revert -m 1of the #354 merge:PatternService,PatternConstants,PatternDataExtractorInterface,WordPressPatternDataExtractorback to their previous state; its tests and theFeature/BlockPatternPest group removed; its CHANGELOG entry removed (never shipped, so nothing to announce).Checked
1312 passed (1316 − the 4 tests of #354); Pint, PHPStan, Rector clean.