ci: let composer audit pass over the abandoned symplify contracts - #358
Merged
Merged
Conversation
driftingly/rector-laravel (dev only, 2.6.2 is the latest) requires symplify/rule-doc-generator-contracts, now marked abandoned on Packagist with no replacement. composer audit fails on abandoned packages, so Code Quality failed on every pull request. Only this package is ignored: any other abandoned package, and every security advisory, still fail the job.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Quality fails on every PR (#356, #357) at
composer audit:symplify/rule-doc-generator-contractsis now abandoned on Packagist, with no replacement. It comes fromdriftingly/rector-laravel(dev only), whose latest version, 2.6.2, still requires it.config.audit.ignore-abandonedlists this one package only: any other abandoned package, and every security advisory, still fail the job. Not reproducible locally:composer auditreads the abandoned flag stored at install time, so only a fresh install (as in CI) sees it — this PR's own Code Quality run is the check.To remove once rector-laravel drops the dependency.