Repository navigation
Conversation
backdate_parameters copies each parameter's first value back to 2015, so the 2021-dated credit lists and the 2017-dated EITC match paid the Act 115 refund in 2015-2020 and the EITC in 2015-2017. Add 2000-01-01 sentinels, start the nonrefundable EITC list and match in 2018 (Act 107, SLH 2017), and zero the Act 115 amounts outside 2021. Also replace the military reserve pay exclusion cap, which used the 2022 amount for 2015-2021, with each year's N-11 instruction value for 2015-2025. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
YAML cases at 2016, 2017, 2018, 2020, 2021 and 2022 for the Hawaii EITC, the Act 115 refund and the credit lists, and military pay exclusion caps for 2015, 2018, 2020, 2021, 2022 and 2025; the 2021 cap case now expects the 2021 instruction amount ($7,152). A grid and Hypothesis property test checks the date invariants for 2015-2026 and compares the exclusion with each year's published cap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
marked this pull request as ready for review
October 13, 2026 13:30
7 tasks done
Contributor
Author
|
Picking this up for the US hub. I'll post a hand-off comment here when it's ready. Generated by Claude Code |
Contributor
Author
|
Picking this up for the US hub. I continue an earlier session's work: it picked this PR up on 2026-11-02 and stopped before pushing anything. I'll post a hand-off comment here when it's ready. Generated by Claude Code |
Main's #10309 already zeroes the Act 115 amounts before 2021 and keeps the 2022+ schedules on purpose, leaving the dated refundable credit list to confine the refund to 2021. Take main's amount files, check 2022 through hi_refundable_credits instead of the standalone refund, and keep both sides' new test cases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LwQq6GA1FXMB3qVPzGgvWQ
Contributor
Author
|
Picking this up for the US hub. I continue the earlier sessions' work on this PR; they pushed nothing. I'll post a hand-off comment here when it's ready. Generated by Claude Code |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backdate_parameters(policyengine_us/tools/parameters.py) copies each parameter's earliest value back to 2015 (FIRST_MODELED_YEAR). Hawaii parameters first dated after 2015 therefore applied in years before the law existed. This PR dates them. It changes no formula, and the 2018–2022 nonrefundable EITC is unchanged.hi_refundable_creditshi_eitc_potentialhi_income_tax2017hi_military_pay_exclusioncapChanges
credits/refundable.yaml: a2000-01-01block withouthi_act_115_rebate. Act 115 (SLH 2022) refunds went only to filers of a 2021 Form N-11 (DOTAX Announcement 2022-03, p.2). The 2018 Form N-11 lists the same three modeled refundable credits (p.3).credits/act_115_rebate/{single,joint}.yaml: no change. This PR first dated the amounts to 2021 only. Main's Guard historical state rebate eligibility and document attribution #10309 has since dated them2020-01-01: 0, which zeroes 2015–2020, and keeps the 2022+ schedules on purpose for standalone calculations. The merge takes main's files, so the dated refundable list keeps the refund out of 2022 and later. The 2022 tests now checkhi_refundable_creditsrather than the standalone refund.credits/non_refundable.yaml:2000-01-01: [],2018-01-01: [hi_eitc],2023-01-01: [].credits/eitc/match.yaml:2000-01-01: 0,2018-01-01: 0.2(was2017-01-01: 0.2). The credit is "effective for taxable years beginning after December 31, 2017" (2018 Form N-356, p.2; Act 107, SLH 2017, per 2018 N-11 instructions, p.2).gov/states/household/state_eitcs.yamlalready startshi_eitcin 2018.subtractions/military_pay/cap.yaml: the file held the 2022 amount ($7,345) from 2021, so 2015–2021 used it. It now has each year's N-11 instructions line 15 amount: 2015 $6,198, 2016 $6,279, 2017 $6,410, 2018 $6,564, 2019 $6,735, 2020 $6,943, 2021 $7,152, 2022 $7,345, 2023 $7,683, 2024 $8,082, 2025 $8,636. 2026 onward is still projected bygov.irs.uprating, now from $8,636. The 2015–2017 instructions are cited from the Wayback Machine because DOTAX removed them.Audit of the other Hawaii income tax parameters first dated after 2015
I checked each against the 2015–2022 N-11 instructions, Form N-311 (2016–2022) and Schedule X (2015, 2017–2021, 2023):
Not audited: the composition of
subtractions/subtractions.yaml.Tests
credits/hi_credit_start_dates.yaml(2016, 2017, 2018, 2020, 2021, 2022) and new cases inhi_eitc.yaml,hi_act_115_rebate.yamlandhi_military_pay_exclusion.yaml. The existing 2021 military cap case now expects $7,152. On main, 16 of these cases fail, all in the years the model was wrong; the 2018, 2020 and 2021 EITC cases and the 2021 refund cases pass on both and guard the years that were right.tests/unit/test_hi_credit_start_dates_properties.py: a 108-household grid and Hypothesis-generated batches in every year 2015–2026, plus a differential test of the exclusion against each year's published cap. On main, 15 of the 17 tests fail.household_state_income_tax.yamlpass, as dosalt_refund_integration.yamland the contrib federal abolition test.test_hi_credit_ordering.pypass. The new cases avoid assertinghi_income_taxin 2018–2022, where Apply Hawaii refundable credits before nonrefundable credits #10202 changes the credit order.Invariants (checked for every grid point and generated household, 2015–2026)
hi_act_115_rebateis 0 before 2021. In 2021 it is $300, or $100 at or above $100,000 federal AGI ($200,000 for joint filers and surviving spouses), times the number of people on the return. It entershi_refundable_creditsonly in 2021.hi_eitc_potentialequals the year's match rate (0 before 2018, 0.2 for 2018–2022, 0.4 from 2023) timeseitc.hi_non_refundable_creditsis 0 before 2018 and from 2023. In 2018–2022 it lies between 0 and min(hi_eitc_potential, tax before nonrefundable credits).hi_refundable_creditsminus the food/excise, dependent care and renters' credits equals the Act 115 refund in 2021,hi_eitcfrom 2023, and 0 otherwise.hi_income_taxequals tax before credits minus refundable credits.hi_military_pay_exclusionequals min(pay, the year's published cap) for 2015–2025 (differential against the instructions).Merge with main (2026-11-03)
act_115_rebate/{single,joint}.yamlandhi_act_115_rebate.yamlconflicted with Guard historical state rebate eligibility and document attribution #10309. The merge takes main's amount files and keeps both sides' test cases. "No refund for 2022" became "No refund in 2022 refundable credits".hi_credit_start_dates.yamlcase 5 and the property test now check the 2022+ refund throughhi_refundable_credits.test_hi_credit_ordering.pypasses on the merged head.Sources
The adopting session on 2026-11-03 could not refetch the DOTAX, Wayback or HRS sources: its network policy blocked files.hawaii.gov, web.archive.org and capitol.hawaii.gov. The military pay caps and the Act 107 date are as an earlier session recorded them. A reviewer with web access should confirm them.
Axiom note
Axiom's Hawaii income tax modules cover tax year 2026 only, and this PR changes 2015–2025 values.
impact: the hub will measure
axiom: (hub files pe-parity before landing)
Coordination: #10202 has merged. #10200 adds
hi_claim_of_right_creditto the 2022+ blocks ofrefundable.yamland merges cleanly with this PR.Generated by Claude Code