Repository navigation
Let a certified pair's test survive the pipeline qualifying that pair - #236
Merged
Merged
Conversation
The pair module's docstring says a variant qualified later for the same pair gets its own id and the pair record stays. The test instead assumed the slug would never name a variant, which fails the results commit for 6.11.0 (#235). It now asks for an id no variant holds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The results commit for policyengine.py 6.11.0 (#235) fails
test_get_record_resolves_a_pair_a_variant_and_the_default, so the builder opened it as a draft. Certifying 6.11.0 adds a replay variant whose id is the slug of the certified pair #229 recorded, and the test's last assertion expected that slug to raise "no replay variant".pipeline/uk_certified_pairs.pyalready describes this case: a variant the pipeline later qualifies for the same pair has its own id, and the pair record stays. So the test was wrong rather than the code. It now asks for an id no variant holds, and holds on main both before and after #235.Verified on #235's tree with this one change: the test file passes. #235 rebuilds after this lands.
axiom: n/a: test only
🤖 Generated with Claude Code