Repository navigation
Hide the UK budget by programme card in the v3 report for now - #1514
Merged
Merged
Conversation
The card's bars do not yet read clearly. The chart, its CSV rows and its tests stay, so a one-line change shows it again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hides the "Budgetary impact by programme" card in the v3 report's Economic impacts tab (UK only) for now. Its bars do not yet read clearly to readers.
EconomicImpactCharts.tsx: aSHOW_BUDGET_BY_PROGRAMME = falseswitch on the card. The chart (charts/BudgetaryImpactByProgramSubPage.tsx), its CSV rows and its own tests (UKBreakdownCharts.test.tsx) stay, so setting the switch totrueshows it again.Tests
EconomicImpactCharts.test.tsx: a UK report has no budget by programme card; the wealth decile cards still show. The card-content test moved out, as the chart's own tests cover it.EconomicImpactCharts.test.tsxandUKBreakdownCharts.test.tsx: 28 tests pass.tsc, ESLint and Prettier are clean.Overlap
#1441 (draft) also edits this card's block in
EconomicImpactCharts.tsx(variable-label gating). This PR changes only the card's condition line, so whichever merges second has a one-line conflict.🤖 Generated with Claude Code