Skip to content

Pin the fact decoder in both UK target kernel hashes #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxGhenis merged 2 commits into from
Oct 29, 2026
Merged

Pin the fact decoder in both UK target kernel hashes #1424

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
543c35f
Pin the fact decoder in both UK target kernel hashes
MaxGhenis Oct 29, 2026
220e9cb
Pin the decoder hash on the selection and problem kernels too
MaxGhenis Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions packages/microcosm-build/tests/engine_free/uk/test_uk_target_compile_modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import importlib
from pathlib import Path

from microcosm.build import ledger_artifact
from microcosm.build import ledger_targets as shared_ledger_targets
from microcosm.build.uk_runtime import (
graph_national,
Expand Down Expand Up @@ -106,6 +107,21 @@ def test_full_target_kernels_hash_the_measure_simulation(monkeypatch):
assert measure_simulation in _hashed_by(kernel, monkeypatch, graph_targets)


def test_full_target_kernels_hash_the_fact_decoder(monkeypatch):
"""full_targets loads the ledger facts inside run through
ledger_artifact's decoder, so an edit there alone re-keys every full-graph
kernel built on this hash: compilation, selection and measure share it,
and the problem kernel embeds it (microcosm#1382). The pin holds even if
no listed module imports ledger_artifact any more."""
for kernel in (
graph_targets.UKFullTargetCompilationKernel(),
graph_targets.UKFullTargetSelectionKernel(),
graph_targets.UKFullMeasureKernel(),
graph_targets.UKFullProblemKernel(),
):
assert ledger_artifact in _hashed_by(kernel, monkeypatch, graph_targets)


def test_national_target_kernel_hashes_the_same_compile_modules(monkeypatch):
hashed = _hashed_by(
graph_national.UKNationalTargetKernel(), monkeypatch, graph_national
Expand All @@ -122,3 +138,14 @@ def test_national_target_kernels_hash_the_measure_simulation(monkeypatch):
graph_national.UKNationalProblemKernel(resolver_factory=None),
):
assert measure_simulation in _hashed_by(kernel, monkeypatch, graph_national)


def test_national_target_kernels_hash_the_fact_decoder(monkeypatch):
"""The national targets load the ledger facts through full_targets and
ledger_artifact's decoder too, so an edit there alone re-keys both
kernels that share this hash (microcosm#1382)."""
for kernel in (
graph_national.UKNationalTargetKernel(),
graph_national.UKNationalProblemKernel(resolver_factory=None),
):
assert ledger_artifact in _hashed_by(kernel, monkeypatch, graph_national)
Loading