Skip to content

Pokemon Home Tera Type Detection Improvements #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mysticial merged 4 commits into from
Aug 20, 2026
Merged

Pokemon Home Tera Type Detection Improvements #1404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
034ab71
Tests for tera types
Dalton-V Aug 4, 2026
5eaab2c
Add filter
Dalton-V Aug 11, 2026
66e499c
Check for GMax to remove false positives
Dalton-V Aug 20, 2026
355a483
losen image validation
Dalton-V Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 90 additions & 4 deletions SerialPrograms/Source/PokemonHome/Inference/PokemonHome_TeraTypeReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,18 @@
#include "CommonTools/Images/ImageFilter.h"
#include "CommonTools/Images/BinaryImage_FilterRgb32.h"
#include "Kernels/Waterfill/Kernels_Waterfill.h"
#include "Pokemon/Pokemon_Types.h"
#include "PokemonHome_GigantamaxDetector.h"
#include "PokemonHome_TeraTypeReader.h"

namespace PokemonAutomation {
namespace Pokemon {
namespace NintendoSwitch {
namespace PokemonHome {

using namespace Kernels;
using namespace Kernels::Waterfill;
using Pokemon::PokemonTeraType;
using Pokemon::POKEMON_TERA_TYPE_SLUGS;

namespace {

Expand Down Expand Up @@ -106,10 +111,10 @@ bool image_validation(const ImageViewRGB32& image){
if (width * height < 100){
return false;
}
if (width > 2 * height){
if (width > 3 * height){
return false;
}
if (height > 2 * width){
if (height > 3 * width){
return false;
}
ImageStats stats = image_stats(image);
Expand Down Expand Up @@ -241,9 +246,10 @@ std::multimap<double, std::pair<PokemonTeraType, ImagePixelBox>> find_tera_type_
{0xffb0b0b0, 0xffffffff},
{0xffc0c0c0, 0xffffffff},
{0xffd0d0d0, 0xffffffff},
{0xffd8d8d8, 0xffffffff},
{0xffe0e0e0, 0xffffffff},
}
);
);
for (PackedBinaryMatrix& matrix : matrices){
find_tera_type_symbol_candidates(candidates, original_screen, image, matrix, max_area_ratio);
}
Expand All @@ -270,6 +276,11 @@ PokemonTeraType read_pokemon_tera_type(
const ImageViewRGB32& original_screen,
const ImageFloatBox& box
){
GigantamaxDetector gmax_detector(COLOR_RED, nullptr, box);
if (gmax_detector.detect(original_screen)){
return PokemonTeraType::NONE;
}

ImageViewRGB32 image = extract_box_reference(original_screen, box);

std::multimap<double, std::pair<PokemonTeraType, ImagePixelBox>> filtered = find_tera_type_symbols(
Expand All @@ -285,5 +296,80 @@ PokemonTeraType read_pokemon_tera_type(
return filtered.begin()->second.first;
}

class Test_TeraTypeReader : public UnitTest{
public:

Test_TeraTypeReader(
const std::string& image,
PokemonTeraType expected
)
: UnitTest("PokemonHome::TeraTypeReader - " + image)
, m_image(UNIT_TEST_RESOURCE_PATH() + image)
, m_expected(expected)
{}

virtual UnitTestResult run(Logger& logger, CancellableScope& scope) const override{
ImageRGB32 image(m_image);
PokemonTeraType result = read_pokemon_tera_type(image, ImageFloatBox(0.463, 0.09, 0.04, 0.06));

if (result == m_expected)
return true;

return "Expected: " + POKEMON_TERA_TYPE_SLUGS().get_string(m_expected) + ", received: " + POKEMON_TERA_TYPE_SLUGS().get_string(result);
};

private:
std::string m_image;
PokemonTeraType m_expected;
};

//TODO: Missing multiple positive test cases for TeraTypeReader.
void add_tests_TeraTypeReader(UnitTestDatabase& database){
database.add<Test_TeraTypeReader>("PokemonHome/BoxView/BoxView-1.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/annihilape_Regular.png", PokemonTeraType::ICE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/bidoof_Regular.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/bulbasaur_Regular.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/bulbasuar_Shiny_Go.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/bulbasuar_Shiny_Lza.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/capskid_Regular.png", PokemonTeraType::GRASS);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/castform_Regular.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/cyclizar_Regular.png", PokemonTeraType::FAIRY);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/dudunsparce_Regular.png", PokemonTeraType::DARK);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/dudunsparce_Regular_Sv.png", PokemonTeraType::NORMAL);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/enamorus_Shiny.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/gimmighoul_Regular.png", PokemonTeraType::GHOST);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/glimmet_Regular.png", PokemonTeraType::ELECTRIC);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/gogoat_Regular.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/greatTusk_Shiny.png", PokemonTeraType::STEEL);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/hatterne_Regular.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/houndstone_Regular.png", PokemonTeraType::GROUND);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/ironBunde_Regular.png", PokemonTeraType::WATER);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/ironBundle_Regular_Sv.png", PokemonTeraType::WATER);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/ironJugulis_Regular.png", PokemonTeraType::FLYING);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/ironThorns_Regular.png", PokemonTeraType::ROCK);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/kilowattrel_Regular.png", PokemonTeraType::POISON);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/kingler_Shiny.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/komala_Regular.png", PokemonTeraType::PSYCHIC);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/krabby_Shiny.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/machamp_Regular.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/pancham_Shiny.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/rapidash_Regular.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/rellor_Regular.png", PokemonTeraType::BUG);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/riolu_Regular.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/rowlet_ShinyAlpha.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/scovillain_Regular.png", PokemonTeraType::FIRE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/slitherWing_Shiny.png", PokemonTeraType::FIGHTING);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/squirtle_Shiny.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/tapuLele_Shiny.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/tatsugiri_Regular.png", PokemonTeraType::DRAGON);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/teddiursa_Regular.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/terapagos_regular.png", PokemonTeraType::STELLAR);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/vulpix_Regular.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/vulpix_Shiny.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/wartortle_Regular.png", PokemonTeraType::NONE);
database.add<Test_TeraTypeReader>("PokemonHome/SummaryScreen/wurmple_Regular.png", PokemonTeraType::NONE);
}

}
}
}
11 changes: 8 additions & 3 deletions SerialPrograms/Source/PokemonHome/Inference/PokemonHome_TeraTypeReader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,26 +8,31 @@
#define PokemonAutomation_PokemonHome_TeraTypeReader_H

#include <map>
#include "Common/Cpp/TestRunners/UnitTestDatabase.h"
#include "CommonFramework/ImageTypes/ImageViewRGB32.h"
#include "CommonFramework/ImageTools/ImageBoxes.h"
#include "Pokemon/Pokemon_Types.h"

namespace PokemonAutomation {
namespace Pokemon {
namespace NintendoSwitch {
namespace PokemonHome {

// Find all tera type symbols inside the image.
std::multimap<double, std::pair<PokemonTeraType, ImagePixelBox>> find_tera_type_symbols(
std::multimap<double, std::pair<Pokemon::PokemonTeraType, ImagePixelBox>> find_tera_type_symbols(
const ImageViewPlanar32& original_screen,
const ImageViewRGB32& image,
double max_area_ratio
);

// Reads the tera type of a Pokemon.
PokemonTeraType read_pokemon_tera_type(
Pokemon::PokemonTeraType read_pokemon_tera_type(
const ImageViewRGB32& original_screen,
const ImageFloatBox& box
);

void add_tests_TeraTypeReader(UnitTestDatabase& database);

}
}
}

Expand Down
2 changes: 2 additions & 0 deletions SerialPrograms/Source/PokemonHome/PokemonHome_Tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include "Common/Cpp/TestRunners/UnitTestDatabase.h"
#include "Inference/PokemonHome_BoxViewDetector.h"
#include "Inference/PokemonHome_SummaryScreenDetector.h"
#include "Inference/PokemonHome_TeraTypeReader.h"
#include "PokemonHome_Tests.h"

namespace PokemonAutomation{
Expand All @@ -17,6 +18,7 @@ namespace PokemonHome{
void add_tests(UnitTestDatabase& database){
add_tests_BoxViewDetector(database);
add_tests_SummaryScreenDetector(database);
add_tests_TeraTypeReader(database);
}


Expand Down
Loading