Skip to content

Fix ONNX starving the main Qt thread. #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mysticial merged 2 commits into from
Aug 16, 2026
Merged

Fix ONNX starving the main Qt thread. #1395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7b1465
Try to actually fix ONNX starving the UI.
Mysticial Aug 15, 2026
fe15ad4
Wire up global OrtEnv to ONNX options.
Mysticial Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions SerialPrograms/Source/ML/Models/ML_ONNXRuntimeHelpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ Ort::Session create_session(
try{
logger.log("Attempting to create Ort::Session with GPU acceleration...");
Ort::SessionOptions gpu_options = create_session_options(model_cache_path, true);
gpu_options.DisablePerSessionThreads();
Ort::Session session{global_ort_env(), onnx_path.c_str(), gpu_options};
logger.log("Ort::Session created");
// when Ort::Ssssion is created, if possible, it will create a model cache
Expand All @@ -221,6 +222,7 @@ Ort::Session create_session(
logger.log("Creating dedicated CPU-only session...");

Ort::SessionOptions cpu_options = create_session_options(model_cache_path, false);
cpu_options.DisablePerSessionThreads();

Ort::Session session{global_ort_env(), onnx_path.c_str(), cpu_options};
logger.log("Ort::Session created");
Expand Down
14 changes: 13 additions & 1 deletion SerialPrograms/Source/ML/Models/ML_OrtEnv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
*/

#include "Common/Cpp/Exceptions.h"
#include "Common/Cpp/PrettyPrint.h"
#include "CommonFramework/Logging/Logger.h"
#include "CommonFramework/Options/Environment/PerformanceOptions.h"
#include "ML_OrtEnv.h"

Expand All @@ -14,7 +16,17 @@ namespace PokemonAutomation{

Ort::ThreadingOptions make_ort_threading_options(){
Ort::ThreadingOptions ret;
ret.SetGlobalIntraOpNumThreads((int)PerformanceOptions::instance().NORMAL_THREAD_POOL.MAX_THREADS);
{
int threads = (int)PerformanceOptions::instance().ONNX_OPTIONS.MAX_INTRA_OP_THREADS;
global_logger_tagged().log("Setting ONNX Intra-Op Threads: " + tostr_u_commas(threads));
ret.SetGlobalIntraOpNumThreads(threads);
}
{
int threads = (int)PerformanceOptions::instance().ONNX_OPTIONS.MAX_INTER_OP_THREADS;
global_logger_tagged().log("Setting ONNX Inter-Op Threads: " + tostr_u_commas(threads));
ret.SetGlobalInterOpNumThreads(threads);
}
ret.SetGlobalSpinControl(0);
return ret;
}

Expand Down
Loading