add BDSP blink detection - #1378
Merged
Mysticial merged 3 commits intoAug 13, 2026
Merged
Conversation
Mysticial
reviewed
Aug 12, 2026
| double best = -1.0; | ||
|
|
||
| for (size_t dy = 0; dy + m_height <= region_height; dy++){ | ||
| for (size_t dx = 0; dx + m_width <= region_width; dx++){ |
Collaborator
There was a problem hiding this comment.
Can you leave a comment here explaining the math here? I see a variance calculation, though I can't tell how similar it is to the image_stats() function or if it duplicates it entirely.
Contributor
Author
There was a problem hiding this comment.
I originally avoided image_stats to work in grayscale rather than RGB, but just using OpenCV's matchTemplate() instead of basically reimplementing it is probably the best option
Mysticial
reviewed
Aug 12, 2026
| } | ||
| return { | ||
| BdspEyeTemplate{ | ||
| "lake_templates/model" + std::to_string(player_model) + ".png", |
Collaborator
There was a problem hiding this comment.
I already merged the Packages PR for this, but can be change the naming convention to:
LakeTemplates/Model-X.png? (title case)
theastrogoth
marked this pull request as draft
August 12, 2026 18:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a few things related to blink detection: