Skip to content

Migrate more Linux GlobalAutoPaths off Qt. #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mysticial merged 2 commits into from
Aug 11, 2026
Merged

Migrate more Linux GlobalAutoPaths off Qt. #1376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df54a76
Migrate more Linux GlobalAutoPaths off Qt.
Mysticial Aug 11, 2026
c670c9f
nope
Mysticial Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 21 additions & 20 deletions SerialPrograms/Source/CommonFramework/GlobalAutoPaths.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,26 +74,27 @@ Filesystem::Path get_application_base_dir_path(){
return std::filesystem::absolute(path).parent_path().lexically_normal();
}
}
QByteArray appDirBytes = qgetenv("APPDIR");
if (!appDirBytes.isEmpty()){
QString appDir = QString::fromUtf8(appDirBytes);
QFile mountinfo(QStringLiteral("/proc/self/mountinfo"));
if (mountinfo.open(QIODevice::ReadOnly | QIODevice::Text)){
while (!mountinfo.atEnd()){
QString line = QString::fromUtf8(mountinfo.readLine()).trimmed();
int dashSep = line.indexOf(QStringLiteral(" - "));
if (dashSep < 0){
continue;
}
QStringList pre = line.left(dashSep).split(u' ', Qt::SkipEmptyParts);
QStringList post = line.mid(dashSep + 3).split(u' ', Qt::SkipEmptyParts);
if (pre.size() < 5 || post.size() < 2){
continue;
}
QString mountPoint = pre[4].replace(QStringLiteral("\\040"), QStringLiteral(" "));
QString source = post[1].replace(QStringLiteral("\\040"), QStringLiteral(" "));
if (mountPoint == appDir && source.endsWith(QStringLiteral(".AppImage"))){
return QDir::cleanPath(QFileInfo(source).dir().absolutePath()).toStdString();
{
char* app_dir = std::getenv("APPDIR");
if (app_dir != nullptr){
QFile mountinfo(QStringLiteral("/proc/self/mountinfo"));
if (mountinfo.open(QIODevice::ReadOnly | QIODevice::Text)){
while (!mountinfo.atEnd()){
QString line = QString::fromUtf8(mountinfo.readLine()).trimmed();
int dashSep = line.indexOf(QStringLiteral(" - "));
if (dashSep < 0){
continue;
}
QStringList pre = line.left(dashSep).split(u' ', Qt::SkipEmptyParts);
QStringList post = line.mid(dashSep + 3).split(u' ', Qt::SkipEmptyParts);
if (pre.size() < 5 || post.size() < 2){
continue;
}
QString mountPoint = pre[4].replace(QStringLiteral("\\040"), QStringLiteral(" "));
QString source = post[1].replace(QStringLiteral("\\040"), QStringLiteral(" "));
if (mountPoint == QString::fromUtf8(app_dir) && source.endsWith(QStringLiteral(".AppImage"))){
return QDir::cleanPath(QFileInfo(source).dir().absolutePath()).toStdString();
}
}
}
}
Expand Down
Loading