Port over tests - #1354
Merged
Merged
Conversation
Dalton-V
marked this pull request as ready for review
August 6, 2026 05:01
Mysticial
approved these changes
Aug 6, 2026
Collaborator
|
Approved, will merge once CI is green. |
Collaborator
|
I tried running these tests locally. It crashes CC when it tries to run the tests for UpdatePopupDetector. All the "Pokemon" tests ran fine. |
Member
Author
|
Yeah something is wrong with how botbase is setup in the test. I haven't had time to dive into it yet. I plan on figuring it out tonight |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.