SwSh Egg program refactor - #1336
Merged
Merged
Conversation
jw098
marked this pull request as draft
July 24, 2026 06:15
…hatched_pokemon()
jw098
marked this pull request as ready for review
July 25, 2026 04:26
Developer-Butters
pushed a commit
to Developer-Butters/Arduino-Source
that referenced
this pull request
Jul 28, 2026
* turn run_batch() into state machine * add NUM_EGGS_IN_PARTY, which affects number of eggs fetched on the first batch * add SwSh::save_game() * add watchers to confirm starting conditions for routines * refactor talk_to_lady_to_fetch_egg * refactor run_bike_loop * fix bike loop routine * add EmptySlotDetector. add check_box() * run check_box() at the start of the program, and after every process_hatched_pokemon() * fix initialization of num_eggs_retrieved and total_eggs_to_fetch * add recovery routine if never spoke to lady. reset position. * update logging * check eggs in box, before process_hatched_pokemon() * Change box view to judge or stats * add parameter for number of expected eggs/empty slots * update logging * update comments * change view to judge at beginning of program * counting eggs and empty slots are split into separate functions * update error message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.