Improve FRLG nature reading - #1312
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tweaks nature OCR for FRLG. Previously, black/white thresholding was done before blurring in a similar but shuffled process compared to some of the other text reading. I'm not sure why this was originally chosen, but switching to just using
preprocess_for_ocrseems to be much more effective, with the added benefit of reducing repeated code.I've also reorganized PokemonFRLG_StatsReader.cpp a bit by moving a few things to helper functions rather than have a lot of stuff happen in one big "read" function.
This fixes the bug reported by Cris and Patrick