GlobalResourceDownloadManager - #1300
Merged
Merged
Conversation
Collaborator
Author
|
Note: RequiredDownload was renamed to ResourceDownload |
Mysticial
reviewed
Jun 24, 2026
| ConditionVariable& m_cv; | ||
| DownloadThread m_download_thread; | ||
|
|
||
| ListenerSet<Listener> m_listeners; |
Collaborator
There was a problem hiding this comment.
During destruction of this class, m_listeners will be destructed before m_download_thread since destruction is in reverse order.
When m_listeners is destructed, the thread is still running and may try to call into it if a download finishes/fails at the same time.
So you should add a destructor for this class and have it explicitly end the thread as the very first thing. I suspect this might be partly responsible for issue you're having earlier where you need to delay destruction of the downloads to after the lock. (though I suspect there's a complicated deadlock going on with all these listeners)
Mysticial
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.