Separate out common patterns in FRLG RNG programs - #1291
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes repeated snippets and patterns across the FRLG RNG programs and moves them to
PokemonFRLG_RngLoopRoutines. The most aggressive change involves the Rare Candy loop for leveling up and narrowing IV ranges -- behavior should still be the same, though.More lines are added than removed, but that's due to a the addition here of some potentially reusable patterns in the Egg RNG program (#1280). These are moved to
PokemonFRLG_RngLoopRoutinesto avoid a really bloated file for the egg program. For the same reason, some of the navigation functions (currently) specific to the egg program were moved toPokemonFRLG_RngNavigation.