Resource Download widgets - popup dialog when starting program - #1276
Closed
jw098 wants to merge 1 commit into
Closed
Resource Download widgets - popup dialog when starting program#1276jw098 wants to merge 1 commit into
jw098 wants to merge 1 commit into
Conversation
Mysticial
reviewed
May 31, 2026
| , m_logger(global_logger_raw(), "Program") | ||
| , m_timestamp(current_time()) | ||
| , m_state(ProgramState::STOPPED) | ||
| , m_download_manager(descriptor.required_resources()) |
Collaborator
There was a problem hiding this comment.
This has me thinking. What if there are multiple programs at the same time and thus multiple DownloadManagers? Will they conflict? Is it possible for two instances to simultaneously try to download the same resource at the same time?
Mysticial
added
PR: Waiting on OP
R2 - Medium Risk
Collaborator
Author
|
Replaced the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.