Home living dex - #1206
Merged
Merged
Conversation
Remove testing code
fix swap bug
Support gigantamax
Dalton-V
marked this pull request as ready for review
May 3, 2026 21:55
pifopi
reviewed
May 4, 2026
pifopi
left a comment
Member
There was a problem hiding this comment.
Quickly went through it ! Thanks for your PR
Mysticial
reviewed
May 6, 2026
Mysticial
reviewed
May 8, 2026
| , VIDEO_DELAY( | ||
| "<b>Capture Card Delay:</b>", | ||
| LockMode::LOCK_WHILE_RUNNING, | ||
| "400 ms" |
Collaborator
There was a problem hiding this comment.
Why do you need this option? No other program has ever needed it.
Mysticial
reviewed
May 8, 2026
| bool go_to_first_slot( | ||
| SingleSwitchProgramEnvironment& env, | ||
| ProControllerContext& context, | ||
| Milliseconds VIDEO_DELAY |
Collaborator
There was a problem hiding this comment.
Oh ugh... this is where you use it. I guess this is just carry over what from the original box sorter had.
I don't block the PR here, but what I'd do is:
- Choose the target location.
- Read your current location.
- Blindly move from current to target using fast button presses.
- Use inference to detect when the cursor reaches the destination.
The blind sequence in #3 would be wrapped with the run_until() in #4. And if you fail to reach the target after the moves are complete + a long grace period (like 5 seconds?), go back to #2 and try again. Thus a self-correcting algorithm that will run as fast as possible without caring about video delay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New program for sorting a living dex.
This shares a lot of code with the normal box sorter. They could probably get combined in the future. Currently the setup for the user is too different. Hopeful that a separate program makes them read the wiki
Depending on the json should cover most of PokemonAutomation/ComputerControl#210
Tasks remaining: