FRLG SID program - #1173
Merged
Merged
Conversation
theastrogoth
marked this pull request as draft
April 13, 2026 05:25
theastrogoth
marked this pull request as ready for review
April 22, 2026 05:04
Contributor
Author
|
This should probably go out at the same time as the StarterRNG program, since most users will need a way to determine their SID. This program in particular would benefit from testing by someone who can use CFW to directly see what SID they've hit. Preliminary testing on my end points to a bigger miss than I expected. |
Koi-3088
pushed a commit
to Koi-3088/Arduino-Source
that referenced
this pull request
May 1, 2026
* add initial adv rng calcs * update cmake files * trainer card detection and tid reading * fix new files in cmake * finish up a few missed things * make constructors public * wip commit * cmake * expose more public methods * another wip commit * fix order of operations for shiny type * fix int comparisons * small fixes * more fixes * fix panels * a few tweaks * small style fix * fix small typo * fix string addition * update with RNG code reorganization * add logging of delay time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a program to help users set their SID.
The SID is determined by the number of RNG advances between finalizing the player character's name and finishing the Professor Oak dialogue. The user manually enters their player name, and then starts the program before confirming it.
SID can't be directly checked without custom firmware or ACE (which isn't available until pretty far into the game). Getting a shiny starter is typically how SID is confirmed, so testing for this will probably go hand in hand with an autonomous shiny starter manip program.
Depends on #1171 and #1172