Skip to content

Add FRLG fishing shiny hunt program - #1145

Closed
Developer-Butters wants to merge 0 commit into
PokemonAutomation:mainfrom
Developer-Butters:PokemonFRLG_ShinyHunt-Fishing
Closed

Add FRLG fishing shiny hunt program#1145
Developer-Butters wants to merge 0 commit into
PokemonAutomation:mainfrom
Developer-Butters:PokemonFRLG_ShinyHunt-Fishing

Conversation

@Developer-Butters

Copy link
Copy Markdown
Contributor

Adds a fishing-based shiny hunt program for FRLG.

Includes adaptive bite timing, automatic rod registration, correct encounter
counting, and integration with the existing shiny detection pipeline.

Follows structure used by other FRLG programs and improves loop speed compared
to static timing approaches.

@Developer-Butters
Developer-Butters marked this pull request as draft March 25, 2026 01:59
@Developer-Butters
Developer-Butters marked this pull request as ready for review March 25, 2026 02:17
@Mysticial

Mysticial commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

Thanks for this! However, this does looks vibe-coded. Vibe-coding is fine, but you need to understand and review what the AI has generated so that you know it as well as if you wrote it yourself.

  • You shouldn't edit CMakeLists.txt. You AI did this probably because that's where file lists usually go. But we moved our file list to a separate file: SourceFiles.cmake.
  • The formatting for your 2 new files is completely off from our coding standard. Please fix this.

@jw098

jw098 commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

It looks like your PR still has made lots of changes to CMakeLists.txt. See the Files Changed tab on Github for all the changes you made. You'll want to revert that change. Also, somehow your AI added a weird line ending to the entire SourceFiles.cmake. You'll want to revert that change as well and add only the 1-2 lines needed to make your program compile.

@Developer-Butters
Developer-Butters force-pushed the PokemonFRLG_ShinyHunt-Fishing branch from 76a2493 to 345be78 Compare March 26, 2026 13:39
@Developer-Butters
Developer-Butters deleted the PokemonFRLG_ShinyHunt-Fishing branch March 26, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants