FRLG: Snorlax added to legendary reset - #1143
Merged
Merged
Conversation
Member
|
Is the program already available to users ? If not I'd say to rename it. If it is, I'm not sure for stats (settings are trivial so not a big deal) |
pifopi
approved these changes
Mar 26, 2026
Member
|
Ah and I'm on phone but aren't enum in PA code full caps with underscore? |
Collaborator
Author
|
The program has been available to users, so we can rename but it might be confusing. I figure Snorlax and Electrode are bonus targets. For enums it's inconsistent, sometimes there's full caps with underscores and sometimes there isn't (ex. in PokemonLA_ShinyDetectedAction.h vs PokemonBDSP_EggHatchFilter.h). Trivial to change if needed though, can do that tomorrow if you want. |
Member
|
All good for me ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In hindsight I should have named it something like Static Encounter Reset (this would also apply to the LGPE version of the program as well). Also tested with Electrode, Press A works for it.