Speed up FindCSP / get all vars in one call and cache for subsequent … - #745
Open
robambalu wants to merge 1 commit into
Open
Speed up FindCSP / get all vars in one call and cache for subsequent …#745robambalu wants to merge 1 commit into
robambalu wants to merge 1 commit into
Conversation
…finds Signed-off-by: Rob Ambalu <robert.ambalu@point72.com>
robambalu
requested review from
AdamGlustein,
alexddobkin and
svatasoiu
as code owners
August 11, 2026 17:03
timkpaine
added
part: build
| list(GET __csp_query_list 2 __csp_lib_path) | ||
| list(GET __csp_query_list 3 __csp_version) | ||
|
|
||
| set(__csp_base_path "${__csp_base_path}" CACHE INTERNAL "csp package base path") |
Collaborator
There was a problem hiding this comment.
Note: CACHE INTERNAL persists across separate CMake configure runs, so reusing a build directory after changing CSP may retain old paths and versions. Can you please verify if that's okay? Should we use a CMake global property instead?
| RESULT_VARIABLE __csp_query_result) | ||
|
|
||
| if(NOT __csp_query_result EQUAL 0) | ||
| message(FATAL_ERROR "Failed to query csp package paths via ${Python_EXECUTABLE}") |
Collaborator
There was a problem hiding this comment.
Note: Previously, a failed CSP import let find_package(CSP REQUIRED) fail while find_package(CSP QUIET) returned CSP_FOUND=FALSE. The new FATAL_ERROR aborts both. Can you please once verify if it even matters? Like do we need to support the REQUIRED/QUIET paramaters?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…finds