Add spaday-based model registry browser - #249
Draft
timkpaine wants to merge 9 commits into
Draft
Conversation
Contributor
Test Results 1 files ± 0 1 suites ±0 3m 12s ⏱️ +52s Results for commit 3e6952b. ± Comparison against base commit a224a37. This pull request removes 67 and adds 147 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 93.57% 93.69% +0.12%
==========================================
Files 176 190 +14
Lines 20500 21287 +787
Branches 1352 1393 +41
==========================================
+ Hits 19183 19945 +762
- Misses 1046 1069 +23
- Partials 271 273 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timkpaine
force-pushed
the
tkp/lazy-registry
branch
from
August 19, 2026 12:55
7624af2 to
9a5bcec
Compare
timkpaine
force-pushed
the
tkp/lazy-registry
branch
from
August 19, 2026 20:33
9a5bcec to
de7f4da
Compare
timkpaine
force-pushed
the
tkp/spaday
branch
2 times, most recently
from
August 19, 2026 20:41
238dc5a to
a40c136
Compare
timkpaine
force-pushed
the
tkp/lazy-registry
branch
from
August 19, 2026 22:23
de7f4da to
06586d8
Compare
timkpaine
force-pushed
the
tkp/lazy-registry
branch
from
August 19, 2026 23:06
06586d8 to
03eac9c
Compare
Collaborator
|
@timkpaine IS this ready for review yet? |
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Replace the hand-built wa-tree with spaday-trees, which derives the hierarchy from registry paths and brings its own search box. Add a Dependencies tab rendering the registry dependency DAG with spaday-dagre; clicking a node selects that model, so the graph shares the sidebar's selection state. Registered names are root-relative and leading-slashed, so they are normalized before matching leaf paths. Bridge the tree's color-scheme to the wa-dark page theme and add a dark toggle. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
timkpaine
commented
Aug 26, 2026
|
|
||
| add_hydra_config_args(parser) | ||
|
|
||
| parser.add_argument("--address", type=str, default="127.0.0.1", help="Address to bind the server to (default: 127.0.0.1).") |
timkpaine
commented
Aug 26, 2026
timkpaine
left a comment
timkpaine
left a comment
Member
Author
There was a problem hiding this comment.
dagre rendering a bit messed up, also its global and not model-local so it looks a bit weird
materializing a model collapses the tree, need to fix
Rename the server bind option from --address to --host. Make the dependency graph model-local: each model's card gets a Dependencies tab showing only what is reachable from that model, with the focused node marked, instead of one global graph in a page-level tab. Models with no dependencies get no tab. Bind the tree's selected_paths to the seeded selection so materializing a model reveals it again after the redirect instead of leaving the tree collapsed. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Label nodes with the full registry path so the hierarchy an entry comes from is visible. Point edges from a dependency to the model that uses it, so the chain reads in dataflow order and the inspected model is the last node. Replace navigate-on-click with a context menu: a pointer event on a node opens a popup naming it, and its Open model action both selects the model and reveals it in the sidebar tree. Each node carries its own menu body with literal actions, because the action DSL cannot build the single-element list the tree's selected_paths needs from a store value. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Materialize a lazy model in place: the button posts to /materialize and refreshes the tree, instead of a form post and a redirect that reloaded the page and collapsed the sidebar. Failures were previously visible only in the server log; the endpoint now returns its error and a toast reports it. Route detail cards with Switch instead of one Show per model, and defer each card to /card so only the visible one is fetched. A 500-model registry drops from 1.6 MiB of tree.json to 129 KiB. Bind the selection to a query parameter, so a model is linkable and back/forward navigate between models, and derive the tree's reveal from it so a deep link expands to the model. Remember the theme with persist. Browse with spaday-trees, badging models that are still configuration, and give the dependency graph full registry paths as labels, edges that point from a dependency to its dependent, and a node context menu in place of navigating on click. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.