chore: regenerate admin-api types for nullable createSectionItem (HNT-2681)#1278
Merged
Conversation
…-2681) The admin-api createSectionItem mutation now returns a nullable SectionItem (Pocket/content-monorepo#395): ML re-adding an item an editor removed manually is an expected no-op that returns null instead of throwing. Regenerated src/api/generatedTypes.ts via `npm run api:generate-types` against admin-api.getpocket.dev. The only change is createSectionItem becoming nullable (Maybe<SectionItem>); the sole consumer (CustomSectionDetails) does not read the mutation result, so no component changes are needed.
|
Claude finished @mmiermans's task in 49s —— View job PR Review: regenerate admin-api types for nullable
|
jpetto
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates
src/api/generatedTypes.tsto track the admin-api schema change in Pocket/content-monorepo#395 (HNT-2681), whereMutation.createSectionItembecame nullable.No application changes
This change just keeps the schema up-to-date; there's no impact to the admin tools from this.
The only consumer,
CustomSectionDetails.tsx, callsrunMutation(createSectionItem, …)and never readsdata.createSectionItem, so the nullable type introduces no TS errors. Also note the null path is ML-only (gated on the ML service user); human curators using this UI never receive null.