fix(curated-corpus): add Polish to the language picker#1276
Conversation
#1274 added Poland (NEW_TAB_PL_PL) as a scheduled surface, but the language picker still omits Polish, so curators can't set/see PL on corpus items and sections. - Add Polish to the `languages` dropdown options (definitions.ts). - Add `Pl = 'PL'` to the generated `CorpusLanguage` enum so the code compiles. This is a manual stopgap: codegen reproduces it once the curated-corpus-api schema change (Pocket/content-monorepo#391) is deployed and `api:generate-types` is re-run against admin-api.
|
Claude finished @mmiermans's task in 51s —— View job PR Review — add Polish to the language picker
Verdict: LGTM ✅ — small, correct, and consistent with the existing pattern. One observation worth a look before merge.
|
| /** The updated rank of the SectionItem in relation to its siblings. */ | ||
| rank: Scalars['Int']; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Generated from dev schema.
Problem
#1274 added Poland (
NEW_TAB_PL_PL) as a scheduled surface, but Polish is missing from the language picker, so curators cannot set or seePLon corpus items and sections.Change
languagesdropdown options (definitions.ts).Pl = 'PL'to the generatedCorpusLanguageenum (generatedTypes.ts).The enum value comes from the backing schema change in Pocket/content-monorepo#391, which is now deployed.
generatedTypes.tswas updated by runningapi:generate-types.