QA tool payments to use catalog data from QA tool platform#207
Open
whooooop wants to merge 2 commits into
Open
QA tool payments to use catalog data from QA tool platform#207whooooop wants to merge 2 commits into
whooooop wants to merge 2 commits into
Conversation
whooooop
force-pushed
the
qatool/payments
branch
from
b9a8c04 to
2ffc835
Compare
Build purchase payload from id and externalId directly instead of local product platform data. Read catalog price and currency from the GET_CATALOG response payload, and map purchases straight from purchaseData. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
whooooop
force-pushed
the
qatool/payments
branch
from
2ffc835 to
d07b18b
Compare
whooooop
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies the QA tool payments flow so it relies on data coming from the QA tool messages instead of locally-stored product platform data.
idandexternalId(options.externalIdor a generated transaction id) instead of looking up local product platform data.price,currencyandpriceCurrencyImagefrom theGET_CATALOGresponse payload instead of the hardcodedGamvalues.purchaseData._paymentsGetProductsPlatformData/_paymentsGetProductPlatformDatahelpers.