Skip to content

Fix for non-required controls becoming required #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lk316 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for non-required controls becoming required #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aceb5a9
Fix for non-required controls becoming required
lk316 Jul 27, 2026
01513a9
bumped version
lk316 Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pos-module-common-styling/modules/common-styling/pos-module.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"machine_name": "common-styling",
"version": "1.38.1",
"version": "1.38.2",
"name": "platformOS common styling"
}
19 changes: 16 additions & 3 deletions pos-module-common-styling/modules/common-styling/public/assets/style/pos-forms.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,27 @@
align-self: start;
}

.pos-form :has([required]:not([type="radio"])) label:after,
.pos-form :has([required]:not([type="radio"])) label strong:after {
/*
The required marker belongs to the field group that holds the required control.
`:has()` is unbounded on its own - `.pos-form :has([required])` is matched by
every ancestor of a required control, not just its group, so any wrapper holding
at least one required control (a `.pos-card` around a set of fieldsets, for
instance) marked every label inside it: optional fields, and fields whose control
is never required at all, such as an upload area. Matching the fieldset keeps the
marker on the group it describes, which is the documented behaviour - labels
placed in a fieldset that has a required input.
*/
.pos-form fieldset:has([required]:not([type="radio"])) label:after,
.pos-form fieldset:has([required]:not([type="radio"])) label strong:after,
.pos-form .pos-form-fieldset:has([required]:not([type="radio"])) label:after,
.pos-form .pos-form-fieldset:has([required]:not([type="radio"])) label strong:after {
color: var(--pos-color-important);

content: " *";
}

.pos-form :has([required]) label:has(strong):after {
.pos-form fieldset:has([required]) label:has(strong):after,
.pos-form .pos-form-fieldset:has([required]) label:has(strong):after {
display: none;
}

Expand Down
Loading