Fix/pos cli mcp server exit crash#728
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pos-cli-mcp: server-wide crash on any fatal tool error
Problem
The MCP server runs all its tools in a single process. Any tool that hit a fatal error path resolved through the CLI's logger.Error, which calls process.exit(1). Because the tools aren't isolated subprocesses, that exit terminated the entire server — one recoverable per-tool error took down every tool at once and forced a manual reconnect.
Why fix
A long-lived server must never be brought down by a single request's error. The failure should be returned to the caller as a normal error response while the server keeps serving all other tools. The server code even had a catchable-error path already written for this case, but it was unreachable because the shared helper exited before it could run.
What was fixed
Fatal errors under the MCP server now throw instead of exiting, so the server's per-request handler catches them and returns a clean error — and stays alive. Standalone CLI behavior is unchanged (it still exits as before).
How