respect best_iteration for early-stopped xgboost models - #44
Merged
Conversation
predict() on an early-stopped booster defaults to trees up to best_iteration, but glex decomposed the full dump, so the components did not sum to the prediction. Filter the tree table to the same subset predict() evaluates, translating rounds to trees to account for multiclass models and num_parallel_tree. Closes #42. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
predict() on an early-stopped booster defaults to trees up to best_iteration, but glex decomposed the full dump, so the components did not sum to the prediction. Filter the tree table to the same subset predict() evaluates, translating rounds to trees to account for multiclass models and num_parallel_tree.
Closes #42.