Skip to content

always all: pre-push hook runs the whole suite, refuses red #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marsrobertson merged 5 commits into from
Sep 19, 2026
Merged

always all: pre-push hook runs the whole suite, refuses red #59

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e1fe67
always all: a pre-push hook that runs the whole suite and refuses red
marsitatheultra Sep 18, 2026
6d96cd2
pre-push: report-only pushes skip the suite, judged on content not ca…
marsitatheultra Sep 18, 2026
e01a97a
pre-push: Marsita's note on the report rule
marsitatheultra Sep 18, 2026
4521b41
pre-push: one log line per use of the report loophole
marsitatheultra Sep 19, 2026
54d3e69
pre-push: always all, no exceptions
marsitatheultra Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions githooks/pre-push
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
#!/usr/bin/env bash
# Always all. The whole suite runs before every push; red means no push.
#
# Marsita, 2026-09-19: "'always all' is simpler :) (as opposed to deciding
# what to run)". 66 s on Gaia, 14 s on the NUC. Deciding which tests a change
# touches costs more thought than the run and is wrong often enough to matter.
#
# GitHub Actions runs the same suite after the push and main requires it green
# to merge a PR. This hook is the earlier, cheaper copy of that gate: it stops
# the red commit leaving the machine at all.
#
# Escape hatch, on purpose and visible: `git push --no-verify`.
set -uo pipefail
REPO="$(git rev-parse --show-toplevel)"
cd "$REPO" || exit 1

PY=""
for v in .venv .venv311 .venv312 .venv313; do
[[ -x "$REPO/$v/bin/pytest" ]] && { PY="$REPO/$v/bin/pytest"; break; }
done
if [[ -z "$PY" ]]; then
echo "pre-push: no venv pytest under $REPO — pushing untested" >&2
exit 0
fi

echo "→ pre-push: full test suite (always all)"
if "$PY" tests -q -x -p no:cacheprovider 2>&1 | tail -3; then
exit 0
fi
echo " ✗ red. Nothing was pushed. Fix it, or push --no-verify and own it." >&2
exit 1
Loading