Fix ValueError in StructureFunction2DStack.calculate_modal_power - #37
Open
richteague wants to merge 1 commit into
Open
Fix ValueError in StructureFunction2DStack.calculate_modal_power#37richteague wants to merge 1 commit into
richteague wants to merge 1 commit into
Conversation
calculate_modal_power unpacked two values from the stack's fit_spiral, which returns three (popts, perrs, model_fns), so every call raised "too many values to unpack (expected 2)". The method had no test coverage and no in-repo caller, so the breakage went unnoticed when fit_spiral gained its per-ring model_fns return. Discard the third element; behaviour is otherwise unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calculate_modal_powercalledfit_spiralexpecting a 2-tuple return, butfit_spiralreturns 3 values, causing aValueError: too many values to unpack.fit_spiral's actual signature.Test plan
pytest tests/)