feat(navbar):added navigation bar - #23
Open
arjuncramesh wants to merge 2 commits into
Open
Conversation
iamaseem
reviewed
Oct 19, 2021
iamaseem
reviewed
Oct 19, 2021
iamaseem
reviewed
Oct 19, 2021
iamaseem
left a comment
iamaseem
left a comment
Collaborator
There was a problem hiding this comment.
please ask questions in the group.
| </div> | ||
| <hr class=" w-full" /> | ||
| </div> | ||
| <a href="###" className="my my- "> |
Collaborator
There was a problem hiding this comment.
Also here my- is not a completed syntax
Collaborator
Author
There was a problem hiding this comment.
updated the corrections
| </button> | ||
| </div> | ||
| <div> | ||
| <div className='border flex py-2.5'> |
Collaborator
There was a problem hiding this comment.
Do not switch between single quotes and double quotes in classNames. stick with one(I suggest to use double quotes for className.
| @@ -1,28 +1,360 @@ | |||
| import { useState } from "react"; | |||
Collaborator
There was a problem hiding this comment.
Using Pascal case for component name is a good practice its really help to differentiate between variable and components names.
PascalCase for components
camelCase for functions
smallcase for variables
corrected the mistakes in navbar.js (camelcase , pascal case and classname )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#18