Add npm-bump action for creating PRs bumping versions of an NPM package - #192
Add npm-bump action for creating PRs bumping versions of an NPM package#192ashbork wants to merge 5 commits into
Conversation
| prefix: | ||
| required: false | ||
| description: "The prefix for the release branch" | ||
| default: "release-" |
There was a problem hiding this comment.
release- is quite a broad name and does not really reflect what was done on this branch. A name suggesting that this is an automatic upgrade would be better. Also, when choosing the default name, take into account the gitlint rules from the gitlint action
There was a problem hiding this comment.
My intent is for this action to be used via workflow-dispatch, so it'd be semi-automatic and usually not triggered by anything else. I'm okay with changing the default, but I suppose we could also just make the prefix required and remove the problem altogether, wdyt?
| pr-title: | ||
| required: false | ||
| description: "The title for the PR. Version will be placed after this content" | ||
| default: "chore: release" |
There was a problem hiding this comment.
same as above, "release" is not what really was done
| - name: Generate PiwikPRO access tokens | ||
| uses: PiwikPRO/github-app-token-generator@v1 | ||
| id: get-token | ||
| with: | ||
| private-key: ${{ inputs.private-key }} | ||
| app-id: ${{ inputs.app-id }} |
There was a problem hiding this comment.
I'm not sure if it is required. If we only plan to create a branch in the same repository as the workflow that runs this action, {{ github.token }} with additional write permissions should be sufficient. The token will be inherited from the workflow that starts this action
name: Example
on:
workflow_dispatch:
permissions:
contents: write # here comes magic
jobs:
create-branch:
runs-on: ubuntu-latest
steps:
- uses: PiwikPRO/actions/javascript/npm-bump@master2 participants
No description provided.