Skip to content

review: a screen for the watch list and the event descriptions - #107

Open
PipFoweraker wants to merge 1 commit into
mainfrom
review/screen-tools
Open

PipFoweraker wants to merge 1 commit into
mainfrom
review/screen-tools

Conversation

@PipFoweraker

Copy link
Copy Markdown
Owner

Asked for by Pip on 2026-11-22. This PR adds the screen review tool for the watch list (pdoom-data#91) and the event descriptions (pdoom-data#88).

Use

python scripts/review/serve_review.py --by "Pip Foweraker"

This opens http://127.0.0.1:8741/, which only this machine can reach. Every click is saved to disk before the page updates.

Tab What you see What you decide
Watch triage All 110 atoms: description, the scan's "why it matters", sources with links, whether the primary source was retrieved, scan confidence and flags, possible duplicates a / b put the atom on Watch, x rejects, ? leaves it unsure. Optional note. Same mapping as triage_watch.py.
Month end Atoms already on Watch Accept / reject (a reason is required, because it is published) / keep watching. Before an accept is recorded, the producer's gate says whether it would actually be served.
Descriptions What is served now, beside the arXiv abstract exactly as it would be served; the full abstract; how pdoom1 shows the record today y accept the abstract, n keep the current text, ? undecided. An optional editorial box takes your own condensation.

Boundaries

  • Editorial vs source. A condensation is stored as editorial: {text, by, kind: "editorialised -- not the source's words"} beside the abstract. The build overlay serves only description, which is always the abstract. pdoom1 can use the editorial text or ignore it, which passes ADR-001's fork-or-ignore test. The test checks this.
  • One implementation of every decision. The keyboard tools and the screen call the same apply_* / build_decision functions, extracted in this PR, so their behaviour can't drift apart.
  • Refuses a second running instance. Two servers would each rewrite the watch list and undo each other's decisions. This actually happened during testing.
  • Refuses POSTs from a foreign Origin. Any web page can send requests to localhost, so this blocks other sites from making decisions through it.

Found while building

pdoom1 shows these 1,129 arXiv events as FEED | <id> -- <title> on the flavour channel, which is filtered out of the default view (pdoom1 godot/scripts/game_manager.gd:809). The description is never shown in-game on that path. Showing descriptions in the game would be new pdoom1 work.

Data

A fresh arXiv fetch covers all 1,129 of 1,129 records. 152 have a differing title, and the tool flags those. 0 would lose characters. As with every dump from this adapter, _metadata.json is tracked and data.jsonl is not.

Verified

  • tests/test_serve_review.py passes all 16 cases against temporary copies; the real watch list was byte-identical afterwards.
  • The page JavaScript passes node --check.
  • The real server served 110 atoms and 1,129 proposals, and refused a foreign-Origin POST with 403.
  • Starting a second instance is refused with exit code 3.
  • check_all.py passes every gating check.

🤖 Generated with Claude Code

Pip, 2026-11-22: "a screen based html tool for me to render decisions on
those monthly events", and for the descriptions, "I want to read each one,
at least to scan it with human eyes. Let's make that tool."

scripts/review/serve_review.py, a local server bound to 127.0.0.1, with
three tabs:
- Watch triage: all 110 atoms, with sources, retrieval status, scan flags
  and duplicate hints in view before the decision. Keys a/b/x/?.
- Month end: accept / reject (a reason is required) / keep watching. The
  producer's own gate is asked before an accept is recorded.
- Descriptions: what is served now beside the arXiv abstract, exactly as it
  would be served, plus how pdoom1 shows the record today. An optional
  EDITORIAL condensation is stored as attributed opinion beside the
  abstract and never served as the description (ADR-001 ignore-a-field).

One implementation of every decision: the mutation logic in triage_watch.py
and review_descriptions.py is extracted into apply_triage / apply_decide /
apply_note / build_decision, and both front ends call those functions. The
keyboard tools behave as before.

Refuses a foreign Origin, and refuses to start a second instance: during
testing a buffered first start looked dead, and the second one took the
next port with its own in-memory copy of the watch list.

tests/test_serve_review.py runs the real server against temp copies (16
cases) and is wired into check_all and CI.

Also: a fresh arXiv fetch of all 1,129 records (152 titles differ, 0 lose
characters). _metadata.json is tracked; data.jsonl is ignored, as for every
dump of this adapter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant