Repository navigation
portability: the guard was red for ten weeks because nothing ran it - #103
Merged
Merged
Conversation
check_source_portability.py was added 2026-08-26 and wired into neither check_all.py nor data-integrity.yml. On 2026-08-29 it went red on a false positive -- webbrowser.open(url) at serve_corpus_review.py:796 read as a file open -- and nobody saw, because a check nothing runs cannot fail anyone. - Narrow the attribute arm: skip .open on a bare `webbrowser` or `os` receiver (NOT_FILE_OPENERS, each with its reason). Path(...).open() and io.open() are still caught. - tests/test_source_portability.py: 9 must-fire, 7 must-not-fire. Against the old guard it fails exactly the two new exclusions. - Run both from check_all.py and from CI. Found by the 2026-11-05 estate protocol pass, card PDOOM-DATA-1. Ruled yes by Pip 2026-11-07. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Merged by pdoom-data-ca (Bort) on Pip's instruction "go now." (2026-11-22 13:50 AEDT, AK106, in order #104 -> #103 -> #105), and then "A" (2026-11-22 14:01 AUSEDT), which chose to continue while the docs workflow is red on main for an unrelated reason: the Ubuntu 26.04 runner has no Python 3.9. Squash merge, with no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Card PDOOM-DATA-1 from the 2026-11-05 estate protocol pass (
coordinationreports/PASS_2026-11-05_pdoom-data.md). Pip said yes on 2026-11-07.What was wrong
scripts/validation/check_source_portability.pywas added on 2026-08-26, but nothing ran it. It wasn't incheck_all.pyor indata-integrity.yml. Runninggit grep check_source_portabilityoutside the file itself returns nothing. Since 2026-08-29 it has exited 1 onserve_corpus_review.py:796, which iswebbrowser.open(url). That's a false positive: the attribute check treats any.openas a file open.Change
NOT_FILE_OPENERSskips.openwhen the receiver is the bare namewebbrowseroros, and each entry records why.Path(...).open(),io.open()andself.os.open()are still flagged.tests/test_source_portability.pyhas 9 cases that must fire and 7 that must not. Run against the old guard, exactly the 2 new exclusions fail.check_all.pyand from CI.Verified
check_all.pypasses every gating check, including the two new ones.check_workflow_disarm.pypasses; no workflow trigger was changed.🤖 Generated with Claude Code