fix: modify GCP input prompter to handle data disk size#391
Open
arnaud-robin wants to merge 1 commit into
Open
fix: modify GCP input prompter to handle data disk size#391arnaud-robin wants to merge 1 commit into
arnaud-robin wants to merge 1 commit into
Conversation
Owner
|
LGTM - tested and works, thanks ! Good catch on this one. I'll merge as soon as review comments are handled |
PierreBeucher
added
the
review comments waiting
Currently GCP interactive cli does not prompt for data disk size, although it is the default way for other deployments. This commit modifies the interactive cli to handle data disk size input, allowing users to specify the size interactively.
arnaud-robin
force-pushed
the
improve-gcp-autoconfig
branch
from
db9bcd3 to
376145f
Compare
Author
|
Thanks for the review, I updated the PR as suggested ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently GCP interactive cli does not prompt for data disk size, although it is the default way for other deployments.
This commit modifies the interactive cli to handle data disk size input, allowing users to specify the size interactively.
Fix #390