PressTarget#129
Conversation
| * | ||
| * @event PressTarget#action | ||
| * @property {Map} detail - The detail object as defined in {@link AbstractControl#detail} | ||
| */ |
| * | ||
| * @event PressTarget#longAction | ||
| * @property {Map} detail - The detail object as defined in {@link PressTarget#detail} | ||
| */ |
| * @class PressTarget | ||
| * @extends Component | ||
| */ | ||
| var PressTarget = exports.PressTarget = Component.specialize( /** @lends PressTarget.prototype # */ { |
There was a problem hiding this comment.
We should use native extends ES class syntax for new content going forward
|
|
||
| /** | ||
| * @class PressTarget | ||
| * @extends Component |
There was a problem hiding this comment.
I didn't realize earlier but looking the PR, I think PressTarget should probably be a subclass of Control rather than Component directly, it should mean less code, like managing active state
| detail: { | ||
| get: function () { | ||
| if (this._detail === null || this._detail === undefined) { | ||
| this._detail = new Map(); |
There was a problem hiding this comment.
Why do we create an empty map here by default?
| * @returns {Map} | ||
| */ | ||
| detail: { | ||
| get: function () { |
There was a problem hiding this comment.
There's no setter for details? We need a teach anyway, but that's also what it's for, how to use things
| @@ -256,11 +256,11 @@ const Button = (exports.Button = class Button extends Control { | |||
| * @default 1000 | |||
| */ | |||
| get holdThreshold() { | |||
There was a problem hiding this comment.
This is inherited, shouldn't be necessary here
There was a problem hiding this comment.
This should move to ActinoTarget, I had already mentioned it in the daily meeting
| super.holdThreshold = value; | ||
| } | ||
|
|
||
| __pressComposer = null; |
There was a problem hiding this comment.
This should move to ActinoTarget, I had already mentioned it in the daily meeting
There was a problem hiding this comment.
This should move to ActinoTarget, I had already mentioned it in the daily meeting
There was a problem hiding this comment.
This should move to ActinoTarget, I had already mentioned it in the daily meeting
There was a problem hiding this comment.
This should move to ActinoTarget, I had already mentioned it in the daily meeting
3 participants
Adds ui/press-target.mod, a basic component wrapper to add a press composer and limited press related functionality to a component