feat: PCI host routing for Card/Token instruments, expand MetaInfo - #35
Merged
Conversation
282000ypk
commented
Mar 23, 2026
282000ypk
commented
Collaborator
- Add PciHostFilter and DeviceOsHeaderFilter via InstrumentRequestFilter interface
- Route Card/Token instruments to cards.phonepe.com via PayContext filter chain
- Expand MetaInfo from udf1-5 to udf1-15 with @Size/@pattern constraints
…o to udf1-15, and add filter pattern - Add PciHostFilter and DeviceOsHeaderFilter via InstrumentRequestFilter interface - Route Card/Token instruments to cards.phonepe.com via PayContext filter chain - Expand MetaInfo from udf1-5 to udf1-15 with @Size/@pattern constraints - Add requestViaAuthRefresh overload with explicit hostUrl in BaseClient - Add pciPgHostUrl to Env; TEST env uses TESTING_URL for WireMock compatibility - Add 26 new tests (PciHostFilter, DeviceOsHeaderFilter, integration, MetaInfo) - Bump version 2.2.2 -> 2.2.3 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- udf1-10: max 256 chars validation - udf11-15: max 50 chars + alphanumeric pattern validation - Null/empty values always allowed across all SDKs - Java: fixed SANDBOX PCI URL; MetaInfo converted record->@DaTa class - Node: fixed 401 retry in requestViaAuthRefreshPci - Go: PciPgHostURL defaults to pgHostURL when empty; MetaInfo validated in Pay() - Python: null udf fields excluded from JSON serialization - PHP: separate request MetaInfo class with validation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sk4x0r
reviewed
Apr 13, 2026
sk4x0r
left a comment
sk4x0r
left a comment
Collaborator
There was a problem hiding this comment.
Review comments on filter chain design and DeviceOS header regression.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.