fix(deps): bump svgo from 3.3.4 to 3.3.5 - #930
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [svgo](https://github.com/svg/svgo) from 3.3.4 to 3.3.5. - [Release notes](https://github.com/svg/svgo/releases) - [Commits](svg/svgo@v3.3.4...v3.3.5) --- updated-dependencies: - dependency-name: svgo dependency-version: 3.3.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
✅ Deploy Preview for phillips-seldon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
davidicus
left a comment
davidicus
left a comment
There was a problem hiding this comment.
@dependabot squash and merge
![phillips-pr-review-agent[bot]](https://avatars.githubusercontent.com/u/12517380?s=60&v=4){kind=small}
There was a problem hiding this comment.
Security patch — approved
This is a Dependabot security bump of svgo from 3.3.4 → 3.3.5. The diff is a single version/integrity-hash change in package-lock.json; no application code is touched.
What changed upstream (SVGO v3.3.5)
Two security advisories addressed in the removeScriptElement plugin backport (GHSA-4vpr-x523-8j87, GHSA-w27v-7q3p-w38r):
- Executable
data:URLs and legacyvbscript:URLs in SVG are now rejected. - Executable HTML inside
<foreignObject>elements is sanitised. - Namespace-prefixed SVG anchors and URL schemes containing ASCII tabs/newlines are handled.
Impact on this repo
svgo is a devDependency consumed via @svgr/core (the SVGR transform pipeline that converts raw SVGs in src/assets/ to .tsx icon components). It is not shipped in the published npm package ("dev": true in the lockfile entry is confirmed). The hardening affects what the build-time optimiser does with SVG source files — a net positive: any SVG in the repo that carried a dangerous data: URL or <foreignObject> script payload would previously have passed through unmodified; it will now be sanitised during the npm run build:icons step.
No API surface, no runtime code, no breaking change risk at v3.3.5 (patch bump). The lockfile integrity hash is consistent with the published package.
I would approve this PR. Merge recommended.
|
🚀 Storybook preview is ready. • Preview: undefined |
|
Tip All tests passed and all changes approved!🟢 UI Tests: 490 tests unchanged |
|
Important Testing in progress…🟢 UI Tests: 490 tests unchanged |
🤖 Dependency Risk Assessment:
|
2 participants
Bumps svgo from 3.3.4 to 3.3.5.
Release notes
Sourced from svgo's releases.
Commits
4380590ci: configure v3 publish tag in package metadata (#2271)4c84fe7ci: publish v3 with npm trusted publishing (#2270)994a9f0fix(removeScriptElement): backport security hardening to v3 (#2269)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for svgo since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.