Skip to content

fix(deps): bump svgo from 3.3.2 to 3.3.4 - #898

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/svgo-3.3.4
Closed

fix(deps): bump svgo from 3.3.2 to 3.3.4#898
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/svgo-3.3.4

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps svgo from 3.3.2 to 3.3.4.

Release notes

Sourced from svgo's releases.

v3.3.4

What's Changed

Security

Support

SVGO v3 is not officially supported, please consider upgrading to SVGO v4 instead. We've backported this fix as there are security implications, but there is no commitment to do this for more complex changes in future.

Consider reading our Migration Guide from v3 to v4 which should ease the process.

v3.3.3

What's Changed

Dependencies

  • Migrates from our unsupported fork of sax (@​trysound/sax) to the upstream version of sax (sax).

Bug Fixes

  • No longer throws error when encountering comments in DTD.

Metrics

Before and after of the browser bundle of each respective version:

v3.3.2 v3.3.3 Delta
svgo.browser.js 910.9 kB 912.9 kB ⬆️ 2 kB

Support

SVGO v3 is not officially supported, please consider upgrading to SVGO v4 instead. We've backported this fix as there are security implications, but there is no commitment to do this for more complex changes in future.

Consider reading our Migration Guide from v3 to v4 which should ease the process.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot
fix(deps): bump svgo from 3.3.2 to 3.3.4
fc59506 
Bumps [svgo](https://github.com/svg/svgo) from 3.3.2 to 3.3.4.
- [Release notes](https://github.com/svg/svgo/releases)
- [Commits](svg/svgo@v3.3.2...v3.3.4)

---
updated-dependencies:
- dependency-name: svgo
  dependency-version: 3.3.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jul 23, 2026
Copilot AI review requested due to automatic review settings July 23, 2026 15:22
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jul 23, 2026
@dependabot dependabot Bot mentioned this pull request Jul 23, 2026
Closed
Copilot AI reviewed Jul 23, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

davidicus
davidicus approved these changes Jul 23, 2026
View reviewed changes

@davidicus davidicus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot squash and merge

@netlify

netlify Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for phillips-seldon ready!

Name Link
🔨 Latest commit fc59506
🔍 Latest deploy log https://app.netlify.com/projects/phillips-seldon/deploys/6a6231a6dc05460008418566
😎 Deploy Preview https://deploy-preview-898--phillips-seldon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@chromatic-com

chromatic-com Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Tip

All tests passed and all changes approved!

🟢 UI Tests: 476 tests unchanged
🟢 UI Review: 238 stories published -- no changes
Storybook icon Storybook Publish: 238 stories published

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

🚀 Storybook preview is ready.

• Preview: https://68b9f094608b90f3cfec5a06-lvmiqufndo.chromatic.com/
• Chromatic build: https://www.chromatic.com/build?appId=68b9f094608b90f3cfec5a06&number=648

@scottdickerson scottdickerson added dependency-upgrade-risk:low and removed dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jul 24, 2026 — with Claude
@scottdickerson Claude

scottdickerson commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Dependency Upgrade Risk Assessment

Risk rating: dependency-upgrade-risk:low

What this library does

svgo (SVG Optimizer) removes redundant/unused data from SVG files, minifies paths, and collapses unnecessary tags. In seldon, it is used as a build-time dev dependency via @svgr/plugin-svgo to compile and optimize SVG source files into React components.

Usage in seldon

svgo is used through @svgr/plugin-svgo, which is configured in svgr.config.cjs. It runs during the build pipeline to transform SVG icons into optimized React components. It is not part of the production library runtime.

Why this is LOW risk

The upgrade (3.3.2 → 3.3.4) spans only 2 patch versions. The changes are a security-focused backport that replaces the @trysound/sax dependency with sax to address a vulnerability. No SVG optimization behavior changes are expected — the plugin configuration and the resulting SVG output should be identical.

Note: svgo v3 is end-of-life. This is the last security backport for the v3 branch. Consider planning a migration to svgo v4 when convenient.

Regression tests to run before merging

  • Run npm run build and confirm SVG icon components are generated without errors
  • Spot-check 2–3 compiled SVG icon components in Storybook to confirm visual output is unchanged
  • Run npm run test to confirm all existing tests pass

Generated by Claude Code

@scottdickerson scottdickerson mentioned this pull request Jul 27, 2026
Merged
7 tasks
@dependabot @github

dependabot Bot commented on behalf of github Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Looks like svgo is up-to-date now, so this is no longer needed.

@dependabot dependabot Bot closed this Jul 27, 2026
@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/svgo-3.3.4 branch July 27, 2026 18:39
@scottdickerson scottdickerson mentioned this pull request Jul 27, 2026
Merged
7 tasks
@scottdickerson

scottdickerson commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Superseded by #908 (merged) — the target version(s) are already at or above the proposed bump on main. Closing as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@davidicus davidicus davidicus approved these changes
@scottdickerson scottdickerson Awaiting requested review from scottdickerson scottdickerson is a code owner

Assignees

No one assigned

Labels

dependency-upgrade-risk:low

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scottdickerson @davidicus